This patch updates xineScope.c to better align with Amarok's code. As a
result, the analyzer is more accurate. For instance, when playing an
audio file and there is a silent spot, the blocks will correctly "drop"
to the bottom, leaving an empty analyzer. The previous behaviour would
leave some blocks "stuck" in their position
See: TDE/codeine#23
Signed-off-by: mio <stigma@disroot.org>
(cherry picked from commit ff2a5768dd)
Most of the code was already borrowed from Amarok, but wasn't properly
finished. This just updates the code to more closely match what is
currently in TDE's Amarok.
The Analyzer still sits in the statusBar(), which is cool, but can have
some delays when watching a video (the video itself is unaffected).
See: TDE/codeine#23
Signed-off-by: mio <stigma@disroot.org>
(cherry picked from commit a3ea0ee70f)
When adding/removing an action to/from the toolbar, the aspect ratio,
audio channel, and subtitle channel menus would disappear from the
parent settings menu.
My understanding is that this happened because nothing was keeping those
menus present (plugged?) when other actions were plugged/unplugged.
This changes it so "Aspect Ratio", "Subtitles", and "Audio Channels"
each are a TDESelectAction that is dynamically filled with items. This
way, each popup menu is still present after other actions being
plugged/unplugged.
Resolves: TDE/codeine#24
Signed-off-by: mio <stigma@disroot.org>
(cherry picked from commit f460840a5e)
VideoWindow::ExposeEvent wasn't being used correctly; it should be a
TQCustomEvent (although, the 3000 type is already being used for
forwarding XINE_PROGRESS_EVENT).
While the pts_per_smpls part never seemed to be encountered, it would
have resulted in a floating point exception as it's always 0. Commented
out to leave a hint as to what the code should be doing.
Resolves: TDE/codeine#2
Signed-off-by: mio <stigma@disroot.org>
(cherry picked from commit 9ef39acd5d)
disabled when xine >= 1.2.10 is detected.
Additional info:
The xine scope plugin is statically linked and therefore written by
accessing internal xine data that are no longer publicly available from
xine 1.2.10.
To add back the scope plugin functionality, the plugin will have to be
converted into a dynamically linked one and further work done to fix the
logic of the plugin itself.
Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
mio
Slávek Banko
gregory guy