Fix two issues in rfbGetClient()

There was an unnecessary assignment, and an assignment of a string that
was to be free()ed later, so it has to be strdup()ed.

Both issues spotted by Roman Held.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
pull/1/head
Johannes Schindelin 15 years ago
parent d11b2abd8c
commit ef33182694

@ -111,10 +111,9 @@ rfbClient* rfbGetClient(int bitsPerSample,int samplesPerPixel,
return NULL;
}
initAppData(&client->appData);
client->programName = NULL;
client->endianTest = 1;
client->programName="";
client->serverHost="";
client->serverHost=strdup("");
client->serverPort=5900;
client->CurrentKeyboardLedState = 0;
@ -265,6 +264,9 @@ rfbBool rfbInitClient(rfbClient* client,int* argc,char** argv) {
} else {
char* colon=strchr(argv[i],':');
if(client->serverHost)
free(client->serverHost);
if(colon) {
client->serverHost=strdup(argv[i]);
client->serverHost[(int)(colon-argv[i])]='\0';

Loading…
Cancel
Save