From 48129adff6c35b093bda523e8c105df65d1ab053 Mon Sep 17 00:00:00 2001 From: Michele Calgaro Date: Thu, 21 May 2020 17:14:22 +0900 Subject: [PATCH] KMix: fixed rounding error on volume reading. This was preventing 1% volume increase steps from working properly. Signed-off-by: Michele Calgaro (cherry picked from commit e1b2705c5dc6c888924dda8f57c88edeb43494ba) --- kmix/mixer.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kmix/mixer.cpp b/kmix/mixer.cpp index d020ef47..f2f3d188 100644 --- a/kmix/mixer.cpp +++ b/kmix/mixer.cpp @@ -568,7 +568,9 @@ int Mixer::volume( int deviceidx ) } else { - return ( vol.getVolume( Volume::LEFT )*100) / volumeRange ; + // Make sure to round correctly, otherwise the volume level will always be 1% too low + // and increments of 1% of top of the value read will result in no change to the actual level + return ((100.0 * vol.getVolume(Volume::LEFT) + volumeRange / 2) / volumeRange); } }