From 1f0d6dd2d76e34cd71700ed77e410040e2a6a8c1 Mon Sep 17 00:00:00 2001 From: gregory guy Date: Fri, 7 Sep 2018 19:29:04 +0200 Subject: [PATCH] reduce scope of pointer variables, this resolves issue#2 Signed-off-by: gregory guy --- yakuake/src/skin_settings.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/yakuake/src/skin_settings.cpp b/yakuake/src/skin_settings.cpp index 8bbbdca..aabfd1b 100644 --- a/yakuake/src/skin_settings.cpp +++ b/yakuake/src/skin_settings.cpp @@ -148,12 +148,14 @@ void SkinSettings::slotPopulate() skin_icon.load(skin_icon_url.path()); bool exists = false; - SkinListItem* item = 0; - + /* SkinListItem* item = 0; + * moved in the while loop to reduce pointer variable scope + */ TQListViewItemIterator it2(skins_list); while (it2.current()) { + SkinListItem* item = 0; item = static_cast(it2.current()); if (item && item->name() == skin_name) exists = true; ++it2; @@ -415,12 +417,14 @@ void SkinSettings::slotResetSelection() void SkinSettings::slotUpdateSelection(const TQString& selection) { selected = selection; - SkinListItem* skin = 0; - +/* SkinListItem* skin = 0; + * moved in the while loop to reduce pointer variable scope + */ TQListViewItemIterator it(skins_list); while (it.current()) { + SkinListItem* skin = 0; skin = static_cast(it.current()); if (skin && skin->name() == selected)