Remove unnecessary scrollbar in TQIconView

Test case (using konqueror icon view):
- The first icons are being shown (no scrollbar yet)
- When there is no space left, a vertical scrollbar is needed
- The vertical scrollbar may cover the right edge of the icons
(in the last column) => an horizontal scrollbar is needed :-(

Solution:
When using ScrollBarMode::Auto, prevent TQt from drawing icons on the
scrollbar area (before the scrollbar is shown).

Related to KDE bug #69589
pull/2/head
Benoit Walter 11 years ago committed by Slávek Banko
parent 9f882f9de7
commit 36ee984c64

@ -1107,7 +1107,7 @@ void QIconViewItem::setText( const QString &text )
if ( view ) { if ( view ) {
if ( QRect( view->contentsX(), view->contentsY(), if ( QRect( view->contentsX(), view->contentsY(),
view->visibleWidth(), view->visibleHeight() ). view->visibleWidthSB(), view->visibleHeightSB() ).
intersects( oR ) ) intersects( oR ) )
view->repaintContents( oR.x() - 1, oR.y() - 1, view->repaintContents( oR.x() - 1, oR.y() - 1,
oR.width() + 2, oR.height() + 2, FALSE ); oR.width() + 2, oR.height() + 2, FALSE );
@ -1159,7 +1159,7 @@ void QIconViewItem::setPixmap( const QPixmap &icon )
if ( view ) { if ( view ) {
if ( QRect( view->contentsX(), view->contentsY(), if ( QRect( view->contentsX(), view->contentsY(),
view->visibleWidth(), view->visibleHeight() ). view->visibleWidthSB(), view->visibleHeightSB() ).
intersects( oR ) ) intersects( oR ) )
view->repaintContents( oR.x() - 1, oR.y() - 1, view->repaintContents( oR.x() - 1, oR.y() - 1,
oR.width() + 2, oR.height() + 2, FALSE ); oR.width() + 2, oR.height() + 2, FALSE );
@ -1195,7 +1195,7 @@ void QIconViewItem::setPicture( const QPicture &icon )
if ( view ) { if ( view ) {
if ( QRect( view->contentsX(), view->contentsY(), if ( QRect( view->contentsX(), view->contentsY(),
view->visibleWidth(), view->visibleHeight() ). view->visibleWidthSB(), view->visibleHeightSB() ).
intersects( oR ) ) intersects( oR ) )
view->repaintContents( oR.x() - 1, oR.y() - 1, view->repaintContents( oR.x() - 1, oR.y() - 1,
oR.width() + 2, oR.height() + 2, FALSE ); oR.width() + 2, oR.height() + 2, FALSE );
@ -1263,7 +1263,7 @@ void QIconViewItem::setPixmap( const QPixmap &icon, bool recalc, bool redraw )
if ( view ) { if ( view ) {
if ( QRect( view->contentsX(), view->contentsY(), if ( QRect( view->contentsX(), view->contentsY(),
view->visibleWidth(), view->visibleHeight() ). view->visibleWidthSB(), view->visibleHeightSB() ).
intersects( oR ) ) intersects( oR ) )
view->repaintContents( oR.x() - 1, oR.y() - 1, view->repaintContents( oR.x() - 1, oR.y() - 1,
oR.width() + 2, oR.height() + 2, FALSE ); oR.width() + 2, oR.height() + 2, FALSE );
@ -5638,8 +5638,8 @@ void QIconView::insertInGrid( QIconViewItem *item )
} }
item->dirty = FALSE; item->dirty = FALSE;
} else { } else {
QRegion r( QRect( 0, 0, QMAX( contentsWidth(), visibleWidth() ), QRegion r( QRect( 0, 0, QMAX( contentsWidth(), visibleWidthSB() ),
QMAX( contentsHeight(), visibleHeight() ) ) ); QMAX( contentsHeight(), visibleHeightSB() ) ) );
QIconViewItem *i = d->firstItem; QIconViewItem *i = d->firstItem;
int y = -1; int y = -1;
@ -5902,7 +5902,7 @@ QIconViewItem *QIconView::makeRowLayout( QIconViewItem *begin, int &y, bool &cha
QIconViewItem *item = begin; QIconViewItem *item = begin;
for (;;) { for (;;) {
x += d->spacing + item->width(); x += d->spacing + item->width();
if ( x > visibleWidth() && item != begin ) { if ( x > visibleWidthSB() && item != begin ) {
item = item->prev; item = item->prev;
while (item && (item->isVisible() == FALSE)) { while (item && (item->isVisible() == FALSE)) {
item = item->prev; item = item->prev;
@ -5933,7 +5933,7 @@ QIconViewItem *QIconView::makeRowLayout( QIconViewItem *begin, int &y, bool &cha
int x; int x;
if ( item == begin ) { if ( item == begin ) {
if ( reverse ) if ( reverse )
x = visibleWidth() - d->spacing - item->width(); x = visibleWidthSB() - d->spacing - item->width();
else else
x = d->spacing; x = d->spacing;
} else { } else {
@ -5969,7 +5969,7 @@ QIconViewItem *QIconView::makeRowLayout( QIconViewItem *begin, int &y, bool &cha
i += r; i += r;
x = i * d->rastX + sp * d->spacing; x = i * d->rastX + sp * d->spacing;
} }
if ( x > visibleWidth() && item != begin ) { if ( x > visibleWidthSB() && item != begin ) {
item = item->prev; item = item->prev;
while (item && (item->isVisible() == FALSE)) { while (item && (item->isVisible() == FALSE)) {
item = item->prev; item = item->prev;
@ -6041,7 +6041,7 @@ QIconViewItem *QIconView::makeRowLayout( QIconViewItem *begin, int &y, bool &cha
QIconViewItem *item = begin; QIconViewItem *item = begin;
for (;;) { for (;;) {
y += d->spacing + item->height(); y += d->spacing + item->height();
if ( y > visibleHeight() && item != begin ) { if ( y > visibleHeightSB() && item != begin ) {
item = item->prev; item = item->prev;
while (item && (item->isVisible() == FALSE)) { while (item && (item->isVisible() == FALSE)) {
item = item->prev; item = item->prev;
@ -6605,4 +6605,24 @@ bool QIconView::isRenaming() const
#endif #endif
} }
int QIconView::visibleWidthSB() const
{
if ( vScrollBarMode() != Auto )
return visibleWidth();
int offset = verticalScrollBar()->isVisible() ? 0
: style().pixelMetric( QStyle::PM_ScrollBarExtent, verticalScrollBar() );
return QMAX( 0, visibleWidth() - offset );
}
int QIconView::visibleHeightSB() const
{
if ( hScrollBarMode() != Auto )
return visibleHeight();
int offset = horizontalScrollBar()->isVisible() ? 0
: style().pixelMetric( QStyle::PM_ScrollBarExtent, horizontalScrollBar() );
return QMAX( 0, visibleHeight() - offset );
}
#endif // QT_NO_ICONVIEW #endif // QT_NO_ICONVIEW

@ -504,6 +504,8 @@ private:
const QPoint &relativeTo, const QPoint &relativeTo,
const QIconViewItem *item ) const; const QIconViewItem *item ) const;
QBitmap mask( QPixmap *pix ) const; QBitmap mask( QPixmap *pix ) const;
int visibleWidthSB() const;
int visibleHeightSB() const;
QIconViewPrivate *d; QIconViewPrivate *d;

Loading…
Cancel
Save