TDE
/
libcaldav
mirror of https://mirror.git.trinitydesktop.org/gitea/TDE/libcaldav
0
0
Fork 0
Code Issues Releases Wiki Activity

Remove unwanted memory allocation for response

Browse Source 
It is expected as pointer to struct response with size fo the struct,
not pointer to the pointer, but never returned to the caller.
It should be allocated by the caller.

Signed-off-by: OBATA Akio <obache@wizdas.com>
pull/2/head
OBATA Akio 5 years ago
parent 665e2b4845
commit 9578e366c2
1 changed files with 6 additions and 24 deletions
Show Stats Download Patch File Download Diff File

30
src/caldav.c
Unescape View File

@ -301,12 +301,9 @@ CALDAV_RESPONSE caldav_get_object(response *result,
CALDAV_RESPONSE caldav_response;
g_return_val_if_fail(info != NULL, TRUE);
g_return_val_if_fail(result != NULL, NOTIMPLEMENTED);
init_runtime(info);
if (!result) {
result = malloc(sizeof(response *));
memset(result, '\0', sizeof(response *));
}
init_caldav_settings(&settings);
settings.ACTION = GET;
settings.start = start;
@ -365,12 +362,9 @@ CALDAV_RESPONSE caldav_getall_object(response* result,
CALDAV_RESPONSE caldav_response;
g_return_val_if_fail(info != NULL, TRUE);
g_return_val_if_fail(result != NULL, NOTIMPLEMENTED);
init_runtime(info);
if (!result) {
result = malloc(sizeof(response *));
memset(result, '\0', sizeof(response *));
}
init_caldav_settings(&settings);
settings.ACTION = GETALL;
if (info->options->debug)
@ -547,12 +541,9 @@ CALDAV_RESPONSE caldav_tasks_get_object(response *result,
CALDAV_RESPONSE caldav_response;
g_return_val_if_fail(info != NULL, TRUE);
g_return_val_if_fail(result != NULL, NOTIMPLEMENTED);
init_runtime(info);
if (!result) {
result = malloc(sizeof(response *));
memset(result, '\0', sizeof(response *));
}
init_caldav_settings(&settings);
settings.ACTION = GETTASKS;
settings.start = start;
@ -611,12 +602,9 @@ CALDAV_RESPONSE caldav_tasks_getall_object(response* result,
CALDAV_RESPONSE caldav_response;
g_return_val_if_fail(info != NULL, TRUE);
g_return_val_if_fail(result != NULL, NOTIMPLEMENTED);
init_runtime(info);
if (!result) {
result = malloc(sizeof(response *));
memset(result, '\0', sizeof(response *));
}
init_caldav_settings(&settings);
settings.ACTION = GETALLTASKS;
if (info->options->debug)
@ -673,12 +661,9 @@ CALDAV_RESPONSE caldav_get_displayname(response* result,
CALDAV_RESPONSE caldav_response;
g_return_val_if_fail(info != NULL, TRUE);
g_return_val_if_fail(result != NULL, NOTIMPLEMENTED);
init_runtime(info);
if (!result) {
result = malloc(sizeof(response *));
memset(result, '\0', sizeof(response *));
}
init_caldav_settings(&settings);
settings.ACTION = GETCALNAME;
if (info->options->debug)
@ -788,12 +773,9 @@ CALDAV_RESPONSE caldav_get_freebusy(response *result,
CALDAV_RESPONSE caldav_response;
g_return_val_if_fail(info != NULL, TRUE);
g_return_val_if_fail(result != NULL, NOTIMPLEMENTED);
init_runtime(info);
if (!result) {
result = malloc(sizeof(response *));
memset(result, '\0', sizeof(response *));
}
init_caldav_settings(&settings);
settings.ACTION = FREEBUSY;
settings.start = start;

Write Preview
Loading…
Cancel
Save