Avoid changes of d->cString for TQString::shared_null to make the value reliable.

This precedes unnecessary allocations, potential use after free and crashes.

Signed-off-by: Slávek Banko <slavek.banko@axis.cz>
master
Slávek Banko 2 years ago
parent 1e77a5569b
commit 93058fb0a3
No known key found for this signature in database
GPG Key ID: 608F5293A04BE668

@ -5999,6 +5999,14 @@ void QString::setSecurityUnPaged(bool lock) {
*/
QCString QString::utf8() const
{
if (!d->cString) {
d->cString = new QCString;
}
if(d == shared_null)
{
return *d->cString;
}
int l = length();
int rlen = l*3+1;
QCString rstr(rlen);
@ -6043,11 +6051,8 @@ QCString QString::utf8() const
++ch;
}
rstr.truncate( cursor - (uchar*)rstr.data() );
if (!d->cString) {
d->cString = new QCString;
}
*d->cString = rstr;
return rstr;
return *d->cString;
}
static QChar *addOne(QChar *qch, QString &str)
@ -6251,6 +6256,10 @@ QCString QString::local8Bit() const
if (!d->cString) {
d->cString = new QCString;
}
if(d == shared_null)
{
return *d->cString;
}
#ifdef QT_NO_TEXTCODEC
*d->cString = QCString(latin1());
return *d->cString;

Loading…
Cancel
Save