Commit Graph

535 Commits (256fa119511e63f85b6554e1140dc26b88ad1913)

Author SHA1 Message Date
Pavel Roskin 6ed4c969f4 Eliminate APP_CC and DEFAULT_CC 8 years ago
Pavel Roskin 30a7a947b1 Don't include config_ac.h from any header files 8 years ago
Pavel Roskin b2d3dcf169 Include config_ac.h from all source files 8 years ago
Koichiro IWAO c126f81d9a add comment to keep xorgxrdp/x11rdp compatibility 8 years ago
Koichiro IWAO e94ab10e14 TLS: new method to specify SSL/TLS version
SSL/TLS protocols only listed in ssl_protocols should be used.
The name "ssl_protocols" comes from nginx.

Resolves #428.
8 years ago
Jay Sorg 657f6f3756 common: use select for SSL_ERROR_WANT_READ, SSL_ERROR_WANT_WRITE tls errors 8 years ago
Jay Sorg e0ac84aaa4 change some casts to long long 8 years ago
Jay Sorg c5e9bc7851 common: print list items as pointers 8 years ago
Jay Sorg 7825246d7a fix warning new since stdint.h change 8 years ago
Pavel Roskin f8d22ce673 aarch64 doesn't require pointers to be aligned 8 years ago
Pavel Roskin dc1e341f5a Constify input arguments of ssl_mod_exp() and ssl_gen_key_xrdp1() 8 years ago
Pavel Roskin 6a3f0a75bd Remove support for OpenSSL older than 0.9.8
It's hard to find an older version of OpenSSL even on long term support
distros.
8 years ago
Jay Sorg d7967ec897 minor arch.h change 8 years ago
Jay Sorg 3b84314a1a arch.h changes to include stdint.h 8 years ago
mirabilos 6257bae23f Add GNU/kFreeBSD support (#645)
* GNU/kFreeBSD is a FreeBSD variant, for code purposes.

* GNU/kFreeBSD uses GNU/Linux-ish init scripts, however.
8 years ago
Idan Freiberg 19375dda7a Merge pull request #426 from metalefty/log-tls-version-and-cipher
TLS: log TLS version and cipher
8 years ago
Idan Freiberg a64e1789c5 Merge pull request #615 from speidy/channels_fixes
Channels improvements
8 years ago
Pavel Roskin f1a521204a Remove redundant function declarations 8 years ago
Koichiro IWAO c89c1318f8 obey coding standard, no logic change 8 years ago
speidy 94cdbdcee6 libxrdp: change channel_code into a meaningful name 8 years ago
Pavel Roskin 6664aac00f Use "void" for empty argument list in declarations
In C, an empty argument list in a declaration means that the function
can accept any arguments. Use "void" instead, it means "no arguments".

C++ treats void and empty list as "no arguments".
8 years ago
volth 26a26ef906 fix build with --enable-xrdpdebug=yes 8 years ago
volth 37b4a14b54 fix build with --enable-xrdpdebug=yes 8 years ago
metalefty 25e5243ecf Merge pull request #553 from jsorg71/libpainter
add libpainter for drawing when client does not have minimum orders
8 years ago
Jay Sorg 1f51586769 add libpainter for drawing when client does not have minimum orders 8 years ago
speidy 4697354044 xrdp_constants: move CAPSET constants to their place 8 years ago
speidy 917aadd2d1 libxrdp: more constants 8 years ago
speidy 3dc0f2860c Merge branch 'surface_cmds' of git://github.com/speidy/xrdp into surface_cmds 8 years ago
speidy 5e39bb1f87 libxrdp: caps, group caps require fastpath output, use FASTPATH_OUTPUT_SUPPORTED constant 8 years ago
Speidy a0cf6030df Merge branch 'devel' of https://github.com/neutrinolabs/xrdp into surface_cmds 8 years ago
jsorg71 5966de4ee2 Merge pull request #536 from jsorg71/unicode
add unicode support
8 years ago
Jay Sorg c264862afe change some magics to defines 8 years ago
Jay Sorg 2f8d3ba9da add unicode support 8 years ago
Pavel Roskin d97155e2f6 Don't use colon to separate IPv6 address from the port
IPv6 addresses can have colons in their names, so the final colon can be
confusing.
8 years ago
speidy 8a0fec5e66 o send RFX tiles as stream (Stream Surface Bits Command)
o silent frame ack logging
o support surface commands in capsets
o fix some wrong constants
8 years ago
Jay Sorg 9a517b34f0 vnc: code cleanup 8 years ago
metalefty 943dec86ca Merge pull request #512 from speidy/devel
xrdp_encoder: do not initialize for non-UNIX rdp clients
8 years ago
Pavel Roskin c6307aa2b0 Use pkg-config to discover OpenSSL
All supported versions of OpenSSL have pkg-config files.
8 years ago
Pavel Roskin 06f4f72e28 Add -ldl to libcommon link flags if it's needed for dlopen() 8 years ago
speidy 1fe048b63d xrdp_encoder: do not initialize for non-UNIX rdp clients
xrdp_encoder: comment about temporary workaround
8 years ago
Koichiro IWAO 849a8075c5 common: If IPv6 not supported, fall back to IPv4
The system to run xrdp does not necessarily support IPv6 even though
it is compiled with IPv6.

Fixes #432.
8 years ago
Koichiro IWAO 40e8194122 TLS: log TLS version and cipher 8 years ago
Itamar Reis Peixoto 7cc1dd2ba8 Merge pull request #460 from metalefty/ipv6/logs
common: Fix client IP address logging when IPv6 is enabled
8 years ago
Pavel Roskin 2dcc69b752 Use g_get_strerror() instead of strerror(errno) for portability 8 years ago
Pavel Roskin 1fe368c5b3 Install headers used by X11rdp and xorgxrdp
Installing the headers makes it possible to compile xorgxrdp as a
separate package, without xrdp sources.
8 years ago
Koichiro IWAO dcf36b592b common: Address family it not always AF_INET6
even if XRDP_ENABLE_IPV6 defined.
8 years ago
Koichiro IWAO b2118450f4 common: Fix client IP address logging when IPv6 is enabled
g_tcp_accept() and g_sck_accept() should use sockadd_in6 when IPv6 is
enabled. The former code logs client IP address always "0.0.0.0" in such
case.

Fixes #412.
8 years ago
Pavel Roskin 4324084d58 Use static inline functions for OpenSSL 1.0 backport
Conditional preprocessor directives spread throughout the code set a bad
example.

The new backport code is located in one place. The compiler checks
argument types. The backport code has no access to the caller variables.
The main code has all advantages of the new, more compact API.
8 years ago
Dominik George e5cf45d1ac
Add backwards compatibility to OpenSSL < 1.1.0. 8 years ago
Dominik George 1b5fb8f1c8
Fix ssl_calls for OpenSSL 1.1.0, closes #458. 8 years ago
Pavel Roskin 6fef1e4eb5 Use const pointers in function arguments when possible 8 years ago
Pavel Roskin bc868b96b1 Remove text2bool() from log.h, there is no such function 8 years ago
Pavel Roskin a618d4f757 Don't use final newline in log calls, it's already appended 8 years ago
Pavel Roskin 7d03d1a3e9 Fix outgoing connections on Mac OSX
connect() on an already established connection returns error with errno
set to EISCONN. Treat it as success.
9 years ago
Pavel Roskin 5465b8c85e Add socklen_t check with substitution, use socklen_t as needed 9 years ago
Pavel Roskin 6f4ffa769c Improve debug information when closing a socket
Don't assume AF_INET family. Don't assume the socket is connected. Report
local address and port. Don't try to close non-sockets and invalid file
descriptors. Report errors getting socket information and closing the
socket. Use more appropriate log levels.
9 years ago
Jay Sorg 8f747e37ca always set SSL_OP_NO_SSLv2 in TLS options 9 years ago
Alex Illsley 47124df4ed new options for xrdp.ini disableSSlv3=yes and tls_ciphers=HIGH and code to implement 9 years ago
Koichiro IWAO ceb4b7b2a4 Fix clipboard when text/filename contains non-ASCII characters
broken by #314. This is compatible with the fix introduced in #314.

To use non-ASCII text/filename in clipboard, chansrv needs to be run
with LC_CTYPE=*.UTF-8 because the behaviour of mbstowcs(3) function
called in chansrv depends on LC_CTYPE[1].  However #314 made
LC_CTYPE=C in chansrv context.  Even if LANG and LC_* are set in
.bashrc, /etc/profile, /etc/locale.conf or something like that,
it doesn't affect in chansrv context because chansrv doesn't source
any of them unlike sesman.

So do not set LC_CTYPE to blank or "C" in g_init() in order to get
g_mbstowcs and g_wcstombs to work properly with non-ASCII UTF-8
characters in any context.

Setting LC_CTYPE to *.UTF-8 doesn't obstruct applying system
language in RHEL [2].

[1] Linux man page says:
      The behavior of mbstowcs() depends on the LC_CTYPE category of
      the current locale.

[2] https://bugzilla.redhat.com/show_bug.cgi?id=1290820
9 years ago
Jay Sorg f4f23b0a7d Include stdint.h, don't redefine MAX/MIN constants if already defined 9 years ago
Jay Sorg d35e57b117 Pixman fixes 9 years ago
Jay Sorg bb7bac2d9b add region intersect 9 years ago
Jay Sorg 58c777783b add more advances region support using pixman 9 years ago
jsorg71 8353baab3d Merge pull request #390 from proski/june21
Cleanups and C++ compatibility
9 years ago
speidy c9b55e3691 sesman: env_set_user, fix potential bof issues 9 years ago
Pavel Roskin ace7d2c822 Declare unified module interface and use it in modules
This fixes loading modules compiled with a C++ compiler. Remote thandle
type, it's unused. Use tintptr for module data. Don't cast pointers to
long, they won't fit on Win64.
9 years ago
Pavel Roskin 2c13ef5c6d Use enum logLevels consistently for log levels 9 years ago
Pavel Roskin 0c72ee2371 Use char* for TLS send and receive
This is consistent with ssl_tls_read() and ssl_tls_write(). C++ warnings
are fixed without adding any casts.
9 years ago
Pavel Roskin 28a1a090b3 Use correct types for ssl and ctx fields in struct ssl_tls 9 years ago
Pavel Roskin d1efb0d5ba Fix signed to unsigned comparisons reported by g++ 6.1.0 9 years ago
Pavel Roskin 5829323ad8 Use g_new or g_new0 when C++ compiler would complain about implicit cast 9 years ago
Pavel Roskin a24df49241 Introduce glib style macros for allocating memory with type 9 years ago
Pavel Roskin aeeb3d2c2e Fix warnings detected by -Wwrite-strings 9 years ago
Pavel Roskin 951e632757 Make program_name constant, don't duplicate or free it 9 years ago
Pavel Roskin 77b380c0b5 Fix format warnings in log_message() calls 9 years ago
Pavel Roskin b1527b7947 Check string format in log_message
Move "printflike" definition to arch.h, it's used both by log.h and
os_calls.h.
9 years ago
Pavel Roskin ae5bb5bf9c Fix incorrect use of "it's" and "its", adjust wording 9 years ago
speidy b38dcf1bb0 xrdp_wm: fix for multimon, draw login window and log window on primary
monitor
9 years ago
Itamar Reis Peixoto 0a6a55b547 Merge pull request #370 from proski/typos
Typo fixes and more
9 years ago
jsorg71 8249091183 Merge pull request #332 from metalefty/freebsd/ipv6
common: add log for g_tcp_connect
9 years ago
Pavel Roskin c3f6e1f58a Use uniform comments for GUIDs 9 years ago
Pavel Roskin ca9cbcafc8 Typo fixes 9 years ago
jsorg71 fdb146740f Merge pull request #360 from proski/format-warnings
Warning fixes
9 years ago
Jay Sorg fac0907a3c trans: set non blocking socket after accept 9 years ago
Pavel Roskin f93074a430 Add unnamed semaphore support on Mac OS
sem_init() is not functional on Mac OS. Use the Grand Central Dispatch
implementation.

Make libscp_lock.c use semaphores through the thread_calls wrapper.
9 years ago
Pavel Roskin e65bd6b7d7 Fix more format warnings 9 years ago
Pavel Roskin 55e12a09d8 Include config_ac.h from common/os_calls.h to enable all format warnings 9 years ago
Jay Sorg 0655272b9c common: call recv/send before can_recv/can_send 9 years ago
Jay Sorg bd6c38af4d common: fix warnings 9 years ago
jsorg71 034ee36f9c Merge pull request #341 from proski/sanity-checks
Sanity checks
9 years ago
Jay Sorg 689ffe79d9 fix warnings, move some calls to os_calls 9 years ago
Jay Sorg 7393579205 Don't attempt to intercept SIGKILL, it doesn't work on any OS 9 years ago
Pavel Roskin 9091c3eef2 Annotate printf-like functions if supported by the compiler
Both GCC and Clang support it. Add a macro from Autoconf archive to check
for format attribute support.
9 years ago
Koichiro IWAO 9460bdb643 common: no logic change, indent 2 -> 4 9 years ago
Koichiro IWAO d01854a341 common: no logic change, fix alignment, whitespaces 9 years ago
Koichiro IWAO 1ed7dbec53 common: add log for g_tcp_connect
in case getaddrinfo(3) might fail.

In FreeBSD, AI_V4MAPPED support for getaddrinfo(3) was very recently
implemented[1].  Most of FreeBSD systems in the world do not have
this implementation yet.  This will be a problem when AI_V4MAPPED
isn't supported and xrdp is built with IPv6 option.  In such a case,
g_tcp_connect always fails.

Of course getaddrinfo(3) might fail in other cases.  The log helps
us to know what's happening.

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198092
9 years ago
Jay Sorg f100036cd9 common: minor fix for older openssl keygen 9 years ago
Jay Sorg 3bc9f1e275 Merge branch 'devel' of git:neutrinolabs/xrdp into devel 9 years ago
Jay Sorg 0d192aee62 common: fix for key generated smaller than asked for 9 years ago
Pavel Roskin 59a5fb0ddb Move headers from EXTRA_DIST to sources, sort alphabetically
There should be no functional difference.
9 years ago