Koichiro IWAO
f11eed3277
chansrv: fix warnings in pulse module
8 years ago
Jay Sorg
a1aff316dc
change log message to long long
8 years ago
Jay Sorg
b5029c2596
sesman: fix warning for 32 bit / 64 bit log entry, trunc to 32 bit
8 years ago
Pavel Roskin
e35b5a4708
Constify string arguments in xrdp-chansrv sources
8 years ago
Szabolcs Seláf
bf4c32c862
Fix calling XChangeProperty in clipboard provide
...
XChangeProperty's last parameter is number of elements, not number of bytes as it's in https://tronche.com/gui/x/xlib/window-information/XChangeProperty.html
Because of this bug Paste did not work in any java applications.
8 years ago
Pavel Roskin
8ee886a5cc
Don't log device_data_len in the code where it may be uninitialized
...
Log device_data_len only in the code that reads it.
8 years ago
Pavel Roskin
9a2e728396
Remove send_channel_data() from devredir.h, it's declared in chansrv.h
...
Include "chansrv.h" from devredir.c to have send_channel_data()
declaration.
8 years ago
Pavel Roskin
c049c3dfd0
rail: remove unneeded call to XGetWindowAttributes()
...
It is already called above "if" with the same arguments.
8 years ago
Pavel Roskin
6664aac00f
Use "void" for empty argument list in declarations
...
In C, an empty argument list in a declaration means that the function
can accept any arguments. Use "void" instead, it means "no arguments".
C++ treats void and empty list as "no arguments".
8 years ago
volth
26a26ef906
fix build with --enable-xrdpdebug=yes
8 years ago
volth
37b4a14b54
fix build with --enable-xrdpdebug=yes
8 years ago
Pavel Roskin
c21b9a78f4
Distribute all files except git and github specific data
...
It is better to distribute a few useless file than not to distribute
needed files.
8 years ago
Pavel Roskin
e46d15ca84
Fix C++ errors and warnings in FUSE code
8 years ago
Pavel Roskin
2ab321a7c6
Use fuse_ino_t for FUSE inodes, not tui32 or int
8 years ago
Pavel Roskin
f622a17c75
Remove write-only FileId variable
8 years ago
Pavel Roskin
46f4025372
Cast pointer to uint64_t through tintptr to avoid warnings
...
Cast to long would damage a pointer on Win64.
8 years ago
Pavel Roskin
e92c4f3b40
Use constant strings to fix warnings
8 years ago
Pavel Roskin
662172012b
Call devredir_cvt_slash() on the path copy, it changes the argument
8 years ago
Pavel Roskin
a4e3952d65
Disable or remove dead code to prevent it from throwing warnings
8 years ago
Pavel Roskin
a547cc3784
Include needed files in chansrv_fuse.c, remove duplicate declarations
8 years ago
Pavel Roskin
bf39fed6e4
Fix misuse of NULL for arithmetic type
8 years ago
Pavel Roskin
4234ed278e
Use FUSE_CFLAGS and FUSE_LIBS from pkg-config
...
Include <fuse_lowlevel.h>, not <fuse/fuse_lowlevel.h>, the include path
should be set up for that.
Don't define _FILE_OFFSET_BITS in one file, FUSE_CFLAGS would enable it
for the whole xrdp-chansrv build if needed.
8 years ago
Pavel Roskin
7fce469cbc
Fix format warnings if FUSE is enabled
8 years ago
Jay Sorg
25fd585d55
chansrv: some fixes to log file path
8 years ago
metalefty
b89956d06e
Merge pull request #485 from proski/code-standards
...
Code standards
8 years ago
Pavel Roskin
35b336272b
Fix compilation with C++
8 years ago
Pavel Roskin
16c3bbdb8d
Remove all tabs in sources
8 years ago
Pavel Roskin
92423a466e
Fix potential buffer overflow in strncat() invocation
...
strncat() will copy at most the specified number of characters and append
the null character on top of that. strlen() doesn't count the final null
character.
8 years ago
Koichiro IWAO
7d017482f6
chansrv: change chansrv log path to ${XDG_DATA_HOME}/xrdp
...
like Xorg's logfile is written to ${XDG_DATA_HOME}/xorg/Xorg.n.log.
If XDG_DATA_HOME is not defined, the log path will be
${HOME}/.local/share/xrdp.
8 years ago
Pavel Roskin
a370306f75
Get rid of EXTRA_LIBS, use variables with more specific names
8 years ago
Pavel Roskin
5c69f3cd57
Eliminate EXTRA_FLAGS, it's a poor name, use AM_LDFLAGS
8 years ago
Pavel Roskin
0422734fc7
Merge EXTRA_DEFINES and EXTRA_INCLUDES into AM_CPPFLAGS
...
AM_CPPFLAGS is a documented Automake variable for C preprocessor flags
that should not be overridden when compiling the package.
There is no need to have two additional variables that are ultimately
merged into AM_CPPFLAGS.
Their names are also confusing. EXTDA_DIST is a documented Automake
variable. Everything else that starts with "EXTRA" is not.
8 years ago
Pavel Roskin
a618d4f757
Don't use final newline in log calls, it's already appended
8 years ago
Koichiro IWAO
9f277e4445
chansrv: pathname also should be URL decoded
...
because 1st argument to clipboard_get_file() is given as URL encoded.
Decoding only filename is incomplete.
Without this fix, clipboard file doesn't work in case pathname
contains non-ASCII characters or non-alphanumeric ASCII characters.
8 years ago
jsorg71
8353baab3d
Merge pull request #390 from proski/june21
...
Cleanups and C++ compatibility
8 years ago
Kentaro Hayashi
8f3fb2f7c8
chansrv: avoid chansrv SEGV when xinode is NULL
...
When xfuse_create_file_in_xrdp_fs is failed, it returns NULL.
Without this fix, xinode->size causes SEGV, so implementation is changed
to return -1 and check the return value in caller.
8 years ago
Jay Sorg
9ccbfb6985
chansrv: added mp3 compression from Speidy
8 years ago
Pavel Roskin
2c13ef5c6d
Use enum logLevels consistently for log levels
9 years ago
Pavel Roskin
cbe413bd8b
Fix return type of devredir_fuse_data_peek and devredir_fuse_data_dequeue
9 years ago
Pavel Roskin
d1efb0d5ba
Fix signed to unsigned comparisons reported by g++ 6.1.0
9 years ago
Pavel Roskin
5829323ad8
Use g_new or g_new0 when C++ compiler would complain about implicit cast
9 years ago
Pavel Roskin
4b05bb2ebd
Mark g_drdynvc_chan_id as extern in g_drdynvc_chan_id, it's in chansrv.c
9 years ago
Pavel Roskin
aaa89ad4e6
Use const unsigned for hex arrays
...
Some constants are too big for the signed type.
9 years ago
Pavel Roskin
aeeb3d2c2e
Fix warnings detected by -Wwrite-strings
9 years ago
Pavel Roskin
77b380c0b5
Fix format warnings in log_message() calls
9 years ago
Pavel Roskin
1403652c72
Remove unused variable in devredir_cvt_from_unicode_len()
9 years ago
Pavel Roskin
f2d326cbed
Remove unused variables from dev_redir_proc_query_dir_response()
9 years ago
Pavel Roskin
0dd0426e6f
Check XGetWindowProperty() return code in clipboard_event_property_notify()
9 years ago
Pavel Roskin
72019d3611
Use better symbols to protect include files
9 years ago
Pavel Roskin
ca9cbcafc8
Typo fixes
9 years ago