b17c45d86f
fix potential fd leak
...
In most cases, checking fd > 0 is not valid. open(2) returns -1 on
error, 0 on stdin, 1 on stdout, 2 on stderr, >2 . The border should be
between -1 and 0. Additionally, between 2 and 3.
Pointed out by: #919
7 years ago
a20d5c29e8
xrdp_caps: remove unneeded comment on case statement
7 years ago
64f15d6553
xrdp_caps: constify and sort capability set
7 years ago
788ae1467a
xrdp_sec: constify color depth value
7 years ago
391c69731c
libxrdp: advertise horizontal mouse wheel capability
7 years ago
9d36983ae7
fix for protocol error when 32 bit and non rfx
8 years ago
8d63c32899
move openssl calls to common/libssl.c, check for defines
8 years ago
a1b0344db5
Use the words "cannot read" rather than "cannot open"
...
as the code actually tests readability.
8 years ago
4f7969b562
Check certificate/privkey readability not existence
...
to fail RDP security negotiation if certificate/privkey is not readable
8 years ago
65c1fe87d7
Log user-friendly message when certificate/privkey is inaccessible
...
We shouldn't assume that xrdp daemon is running under root privilege.
In many cases, root privilege is not really needed for xrdp daemon.
xrdp may fail to load certificate/privkey due to lack of permissions
when running under user privilege. Checking existence of files is not
enough and xrdp should output user-friendly log in such case.
Reported by Debian user in bug 856436 [1].
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856436
8 years ago
148afd1170
Rename file_loc.h to xrdp_sockets.h, install it
...
Include xrdp_sockets.h directly, not through headers.
8 years ago
1c70e4915f
xrdp_orders_rail: fix resulting unicode length
8 years ago
22f0b05b03
libxrdp: window update, simplify length checks
8 years ago
954b68314d
xrdp_orders_rail: fix g_mbstowcs error handling
8 years ago
dfd639a3a9
RAIL: use fixed size length for window texts
8 years ago
fdb6195bbc
rail, text length checks
8 years ago
3c95a2aef2
rail, text length checks
8 years ago
2f382d2a16
libxrdp: print connected client name to log
8 years ago
9d578d9c5f
libxrdp: fix misleading variable name
8 years ago
b905967ba6
libxrdp: improve unicode_in
8 years ago
43899b7e0c
Allocate space for tls_ciphers dynamically
8 years ago
6ed4c969f4
Eliminate APP_CC and DEFAULT_CC
8 years ago
9cdcb38d87
Fix memory leak in tls_ciphers parsing
8 years ago
08ba9ed4a8
Remove useless comment, no logic change
...
Now client addr and port are properly logged.
8 years ago
30a7a947b1
Don't include config_ac.h from any header files
8 years ago
b2d3dcf169
Include config_ac.h from all source files
8 years ago
1c355409a7
Fix compilation on MacOS
...
xrdp_rdp.c includes openssl/ssl.h now, make sure the OpenSSL include path
is used.
8 years ago
096baec331
no cast is needed for NULL
8 years ago
849c1a22a2
TLS: switch ssl_protocols to a comma separated list
8 years ago
c64e9992e6
TLS: warn if no SSL/TLS protocols enabled
8 years ago
e94ab10e14
TLS: new method to specify SSL/TLS version
...
SSL/TLS protocols only listed in ssl_protocols should be used.
The name "ssl_protocols" comes from nginx.
Resolves #428 .
8 years ago
7825246d7a
fix warning new since stdint.h change
8 years ago
0bb048d35e
Fix several cases of discarding return values
8 years ago
482671fd18
Merge pull request #625 from speidy/proxy_session_info
...
Pass session info in proxy mode
8 years ago
19375dda7a
Merge pull request #426 from metalefty/log-tls-version-and-cipher
...
TLS: log TLS version and cipher
8 years ago
b7da395b5e
libxrdp: use constant RDP_DATA_PDU_LOGON
8 years ago
0a5bc44a0b
libxrdp: use log_message
8 years ago
6f74efa70a
add session_info
...
Conflicts:
libxrdp/libxrdp.h
8 years ago
f29a98b243
TLS: log client port in addition to ssl protocol and cipher
8 years ago
6810aa3f79
libxrdp: libxrdp_send_to_channel, improve error message
8 years ago
58d8cb0fd2
libxrdp: ignore incoming channels with empty names
8 years ago
94cdbdcee6
libxrdp: change channel_code into a meaningful name
8 years ago
bcaa1709e0
Fix all warnings in TurboJPEG code
...
Actually use the error code from tjCompress() by logging the errors.
Make sure width is more than zero before filling the pad with the last
pixel data.
8 years ago
5194311d9d
Merge pull request #611 from volth/support-enable-xrdpdebug=yes-2
...
fix build with --enable-xrdpdebug=yes
8 years ago
26a26ef906
fix build with --enable-xrdpdebug=yes
8 years ago
70e9132ab1
xrdp: add some logging, remove unused var
8 years ago
a62c467f71
libxrdp: frame acks, make sure max unacked frames value is valid.
8 years ago
a96c91b38e
libxrdp: fix Fast-Path Synchronize Update message
8 years ago
38253f1371
libxrdp: add XRDP_RFXCODEC to Makefile.am
8 years ago
1753f6317c
Merge pull request #550 from jsorg71/bitmap_update
...
fixes for bitmap update
8 years ago
Koichiro IWAO
Jay Sorg
Pavel Roskin
speidy
volth