Fix warnings regarding return value being ignored

pull/2/head
Timothy Pearson 9 years ago
parent 6095bc10ad
commit 5d20ad97bf

@ -1114,7 +1114,9 @@ SetGid( const char *name, int gid )
#ifdef HAVE_INITGROUPS #ifdef HAVE_INITGROUPS
if (initgroups( name, gid ) < 0) { if (initgroups( name, gid ) < 0) {
LogError( "initgroups for %s failed: %m\n", name ); LogError( "initgroups for %s failed: %m\n", name );
setgid( 0 ); if (setgid(0) != 0) {
LogError("setgid(0) failed\n");
}
return 0; return 0;
} }
#endif /* QNX4 doesn't support multi-groups, no initgroups() */ #endif /* QNX4 doesn't support multi-groups, no initgroups() */
@ -1642,7 +1644,10 @@ StartClient()
} }
} else { } else {
cdroot: cdroot:
chdir( "/" ); if (chdir( "/" ) != 0) {
LogError( "Cannot change directory to %s\n", "/" );
goto logerr;
}
tmperr: tmperr:
ASPrintf( &lname, "/tmp/xerr-%s-%s", curuser, td->name ); ASPrintf( &lname, "/tmp/xerr-%s-%s", curuser, td->name );
unlink( lname ); unlink( lname );
@ -1828,13 +1833,19 @@ ReadDmrc()
exit( 0 ); exit( 0 );
if (!(data = iniLoad( fname ))) { if (!(data = iniLoad( fname ))) {
static const int m1 = -1; static const int m1 = -1;
write( pfd[1], &m1, sizeof(int) ); if (write(pfd[1], &m1, sizeof(int)) < 0) {
exit( 0 ); return GE_Error;
}
exit(0);
} }
len = strlen( data ); len = strlen( data );
write( pfd[1], &len, sizeof(int) ); if (write(pfd[1], &len, sizeof(int)) < 0) {
write( pfd[1], data, len + 1 ); return GE_Error;
exit( 0 ); }
if (write(pfd[1], data, len + 1) < 0) {
return GE_Error;
}
exit(0);
} }
close( pfd[1] ); close( pfd[1] );
free( fname ); free( fname );

Loading…
Cancel
Save