Commit Graph

2612 Commits (dc60a80b862a2e88b1179e8478b6d1ffb7c8249f)
 

Author SHA1 Message Date
Pavel Roskin dc60a80b86 Memory leak fix: keep X server path in the parameter list
g_cfg->xorg_params, g_cfg->vnc_params and g_cfg->rdp_params don't have
auto_free enabled, so removing an item from one of those lists won't free
its contents.

It's better not to change those lists, as they represent the actual
config file and could be reused. Instead, omit the 0th parameter (the
executable path) from copying to xserver_params.

Found by Valgrind.
8 years ago
Pavel Roskin e17a56efb6 Call auth_end() exactly once in scp_v0_process()
As discovered by Valgrind, it wasn't called at all in case of a
successful session creation, which leaked memory.
8 years ago
Pavel Roskin 65ac8e758b Fix memory leak: free session data
Call scp_session_destroy() in the functions that call
scp_session_create() and nowhere else.

As found by Valgrind, the session data is not freed if the session is
created successfully.
8 years ago
Itamar Reis Peixoto 8bf28e45c4 Merge pull request #445 from proski/noextra
Avoid using non-standard Automake variables starting with "EXTRA"
8 years ago
Pavel Roskin a370306f75 Get rid of EXTRA_LIBS, use variables with more specific names 8 years ago
Pavel Roskin 5c69f3cd57 Eliminate EXTRA_FLAGS, it's a poor name, use AM_LDFLAGS 8 years ago
Pavel Roskin 0422734fc7 Merge EXTRA_DEFINES and EXTRA_INCLUDES into AM_CPPFLAGS
AM_CPPFLAGS is a documented Automake variable for C preprocessor flags
that should not be overridden when compiling the package.

There is no need to have two additional variables that are ultimately
merged into AM_CPPFLAGS.

Their names are also confusing. EXTDA_DIST is a documented Automake
variable. Everything else that starts with "EXTRA" is not.
8 years ago
Koichiro IWAO 85e98d211a Update file-loc.txt 8 years ago
metalefty 0c4c52878a Merge pull request #444 from proski/trivial
Simple changes, mostly log messages and documentation
8 years ago
Pavel Roskin 6fef1e4eb5 Use const pointers in function arguments when possible 8 years ago
Pavel Roskin bc868b96b1 Remove text2bool() from log.h, there is no such function 8 years ago
Pavel Roskin 09746fcebc Leave only one "autorun" in xrdp.ini, improve comment 8 years ago
Pavel Roskin c3b99de739 Fix wrong comments in sesman config printing code 8 years ago
Pavel Roskin bf08892622 Fix incorrect description of auth_userpass() return value 8 years ago
Pavel Roskin a618d4f757 Don't use final newline in log calls, it's already appended 8 years ago
Pavel Roskin 424cef464b Log malloc errors with LOG_LEVEL_ERROR 8 years ago
Pavel Roskin 9ac592b218 Don't use term "missing" when using default files, it's too alarming
Also improve messages when non-absolute path is rejected.
8 years ago
Pavel Roskin acdfc94511 Merge prog_std.txt into coding_style.md 8 years ago
metalefty c9108242cd Merge pull request #434 from proski/buildx
Fixes for x11rdp build
8 years ago
Koichiro IWAO ee3a38f93d xrdp: librfxcodc link fix
as same fix as done in 4a815d5 for libpainter
8 years ago
jsorg71 1a69dbe119 Merge pull request #435 from metalefty/update-submodules
Update xorgxrdp and librfxcodec
8 years ago
Pavel Roskin bc5e166f13 Move libXdmcp above libxcb, libxcb can use it 8 years ago
Pavel Roskin 293d8b4b79 Add *.a to top .gitignore, add xorg/X11R7.6/.gitignore 8 years ago
Pavel Roskin 3cf67c684b buildx.sh: force forward patch, don't ask whether to revert 8 years ago
Koichiro IWAO 3bdce59160 librfxcodec=845ee8c 8 years ago
Koichiro IWAO 1f587945cf xorgxrdp=822e3b8 8 years ago
Pavel Roskin 6247a3afac buildx.sh: remove special case for python, it's not built anymore 8 years ago
Pavel Roskin d602e71465 Change compilation order to resolve dependencies
With this change, buildx.sh succeeds on a system without pre-existing
X11 installation.
8 years ago
Pavel Roskin b2bbaef640 buildx.sh: utilize all available CPUs when compiling 8 years ago
Pavel Roskin 8e7d12ff50 buildx.sh: "clean" is a constant string, not a semantic variable 8 years ago
Pavel Roskin 22c370a6a1 buildx.sh: use "mkdir -p" to create $PREFIX_DIR, don't retry
Improve messages about $PREFIX_DIR
8 years ago
metalefty 132cc10f75 Merge pull request #431 from metalefty/remove-python-from-x11rdp
X11rdp: remove python as it isn't really needed these days
9 years ago
Koichiro IWAO 1612730140 X11rdp: remove python as it isn't really needed these days
Closes #399.
9 years ago
Jay Sorg b24f8d8fef remove a debug message 9 years ago
Jay Sorg 409878666f xrdp: handle 3 byte PDU 9 years ago
metalefty f0c0976d1d Merge pull request #411 from proski/socket_close
Cleaning up bogus messages about closing "established" connections to NULL:NULL
9 years ago
metalefty ba78399122 Merge pull request #417 from metalefty/apply-keyboard-options
Apply xkb options for x11rdp
9 years ago
Pavel Roskin 7d03d1a3e9 Fix outgoing connections on Mac OSX
connect() on an already established connection returns error with errno
set to EISCONN. Treat it as success.
9 years ago
Pavel Roskin 5465b8c85e Add socklen_t check with substitution, use socklen_t as needed 9 years ago
Pavel Roskin 49ae93130a Improve message about listening socket is a wrong state 9 years ago
Pavel Roskin 945833a94f Don't close socket in scp_process_start(), the caller closes it 9 years ago
Pavel Roskin f7c27f05cf g_term_event is a wait object, not TCP socket, delete it correctly 9 years ago
Pavel Roskin 931fb90832 sesrun: remove unused g_sck and write-only g_pid 9 years ago
Pavel Roskin d605310bdc sesman: don't close listening socket in signal handler
It is closed when the main loop terminates.
9 years ago
Pavel Roskin 6f4ffa769c Improve debug information when closing a socket
Don't assume AF_INET family. Don't assume the socket is connected. Report
local address and port. Don't try to close non-sockets and invalid file
descriptors. Report errors getting socket information and closing the
socket. Use more appropriate log levels.
9 years ago
metalefty c02f18993a Merge pull request #420 from proski/uk-keyboard
Add UK English keyboard and code to generate it
9 years ago
Koichiro IWAO e2d4b65787 libxrdp: cleanup log log in xrdp_load_keyboard_layout 9 years ago
Pavel Roskin 7e8863b0f2 Add UK English keyboard and code to generate it 9 years ago
Koichiro IWAO 2488159645 libxrdp: log keyboard type/subtype 9 years ago
Koichiro IWAO 644242fc53 libxrdp: log keyboard options 9 years ago