TDE
/
tdelibs
mirror of https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs
0
0
Fork 0
Code Issues Releases Wiki Activity

Fix uninitialized class member variables in network manager

Browse Source
pull/16/head
Timothy Pearson 12 years ago
parent 5b16595440
commit 85a072d6bf
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File

15
tdecore/tdenetworkconnections.cpp
Unescape Escape View File

@ -94,9 +94,10 @@ TDENetMask::~TDENetMask() {
void TDENetMask::fromCIDRMask(unsigned char mask, bool ipv6) { void TDENetMask::fromCIDRMask(unsigned char mask, bool ipv6) {
unsigned int i; unsigned int i;
unsigned int j; unsigned int j;
unsigned int internalMask = mask;
if (!ipv6) { if (!ipv6) {
m_ipv4NetMask = 0; m_ipv4NetMask = 0;
for (i=31;i>=(32-mask);i--) { for (i=31;i>=(32-internalMask);i--) {
SET_BIT(m_ipv4NetMask, i); SET_BIT(m_ipv4NetMask, i);
} }
m_isIPV6 = false; m_isIPV6 = false;
@ -106,7 +107,7 @@ void TDENetMask::fromCIDRMask(unsigned char mask, bool ipv6) {
j=0; j=0;
unsigned int byteno=0; unsigned int byteno=0;
memset(maskarray.c, 0, 16); memset(maskarray.c, 0, 16);
for (i=127;i>=(128-mask);i--) { for (i=127;i>=(128-internalMask);i--) {
SET_BIT(maskarray.c[byteno], (i-((15-byteno)*8))); SET_BIT(maskarray.c[byteno], (i-((15-byteno)*8)));
j++; j++;
if (j>7) { if (j>7) {
@ -326,9 +327,14 @@ TDENetworkIEEE8021xConfiguration::TDENetworkIEEE8021xConfiguration() {
valid = false; valid = false;
allowedValid = false; allowedValid = false;
secretsValid = false; secretsValid = false;
type = TDENetworkIEEE8021xType::None;
fastProvisioningFlags = TDENetworkIEEE8021xFastFlags::None; fastProvisioningFlags = TDENetworkIEEE8021xFastFlags::None;
phase2NonEAPAuthMethod = TDENetworkIEEE8021xType::None;
phase2EAPAuthMethod = TDENetworkIEEE8021xType::None;
passwordFlags = TDENetworkPasswordHandlingFlags::None; passwordFlags = TDENetworkPasswordHandlingFlags::None;
binaryPasswordFlags = TDENetworkPasswordHandlingFlags::None; binaryPasswordFlags = TDENetworkPasswordHandlingFlags::None;
privateKeyPasswordFlags = TDENetworkPasswordHandlingFlags::None;
phase2PrivateKeyPasswordFlags = TDENetworkPasswordHandlingFlags::None;
forceSystemCaCertificates = false; forceSystemCaCertificates = false;
} }
@ -444,14 +450,15 @@ TDENetworkIPConfiguration::~TDENetworkIPConfiguration() {
TDENetworkWiFiSecurityConfiguration::TDENetworkWiFiSecurityConfiguration() { TDENetworkWiFiSecurityConfiguration::TDENetworkWiFiSecurityConfiguration() {
valid = false; valid = false;
secretsValid = false; secretsValid = false;
wepKeyIndex = 0;
keyType = TDENetworkWiFiKeyType::Other; keyType = TDENetworkWiFiKeyType::Other;
authType = TDENetworkWiFiAuthType::Other; authType = TDENetworkWiFiAuthType::Other;
wpaVersion = TDENetworkWiFiWPAVersionFlags::Any; wpaVersion = TDENetworkWiFiWPAVersionFlags::Any;
cipher = TDENetworkWiFiConnectionCipher::None;
wepKeyFlags = TDENetworkPasswordHandlingFlags::None; wepKeyFlags = TDENetworkPasswordHandlingFlags::None;
wepKeyIndex = 0;
wepKeyType = TDENetworkWepKeyType::Hexadecimal;
pskFlags = TDENetworkPasswordHandlingFlags::None; pskFlags = TDENetworkPasswordHandlingFlags::None;
leapPasswordFlags = TDENetworkPasswordHandlingFlags::None; leapPasswordFlags = TDENetworkPasswordHandlingFlags::None;
wepKeyType = TDENetworkWepKeyType::Hexadecimal;
} }
TDENetworkWiFiSecurityConfiguration::~TDENetworkWiFiSecurityConfiguration() { TDENetworkWiFiSecurityConfiguration::~TDENetworkWiFiSecurityConfiguration() {

Write Preview
Loading…
Cancel
Save